feat(instance): import file for cloud-init #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtherin
force-pushed
the
importfile
branch
2 times, most recently
from
98dd3fb to
53c1749
Compare
4 tasks
|
Reimplemented using ArgSpecs. |
|
Hmm, seems not working on user-data, will investigate tomorrow. |
jerome-quere
suggested changes
Nov 18, 2020
internal/core/arg_file_content.go
Outdated
| } | ||
|
|
||
| for _, v := range fieldValues { | ||
| if v.Kind() != reflect.String { |
There was a problem hiding this comment.
What about StringPointer ? is it handled in getValuesForFieldByName ?
@jtherin can you please add at least an example too 🙏 |
| fieldName := strcase.ToPublicGoName(argSpec.Name) | ||
| fieldValues, err := getValuesForFieldByName(reflect.ValueOf(cmdArgs), strings.Split(fieldName, ".")) | ||
| if err != nil { | ||
| continue |
There was a problem hiding this comment.
Maybe we should return an error and not fail silently ?
There was a problem hiding this comment.
validate.go line 48 et 78 also execute getValuesForFieldByName, log an info and continue.
It would not be too much to log the same info many times ?
jerome-quere
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of file import for cloud-init
$ scw instance server create image=ubuntu_focal name=test cloud-init=@/tmp/test