Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qa): add a qa about commands without examples #1298

Merged
merged 8 commits into from
Aug 11, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


internal/qa/qa.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute previously approved these changes Aug 11, 2020
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit but LGTM

internal/qa/qa.go Outdated Show resolved Hide resolved
@kindermoumoute kindermoumoute dismissed jerome-quere’s stale review August 11, 2020 11:25

duplicates latest review

Co-authored-by: Olivier Cano <[email protected]>
@remyleone remyleone merged commit b6bff44 into scaleway:master Aug 11, 2020
@remyleone remyleone deleted the qa_missing_example branch August 11, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants