Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(baremetal): add a custom enum marshaling for ping status #1024

Merged
merged 6 commits into from
May 25, 2020
Merged

feat(baremetal): add a custom enum marshaling for ping status #1024

merged 6 commits into from
May 25, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone linked an issue May 25, 2020 that may be closed by this pull request
add a custom enum marshaling for ping status in baremetal install #914
Closed
jerome-quere
jerome-quere approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 96aa085 into scaleway:v2 May 25, 2020
remyleone added a commit to remyleone/scaleway-cli that referenced this pull request May 26, 2020
@remyleone
feat(baremetal): add a custom enum marshaling for ping status (scalew…
6517c51 
…ay#1024)
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@paulden
fix(domain-record): Add dns_zone to tfstate when using terraform impo…
e41e972 
…rt (scaleway#1024)
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
elastic-metal Elastic-metal issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a custom enum marshaling for ping status in baremetal install
2 participants
@remyleone @jerome-quere