fix(instance): make inbound-default-policy and outbound-default-polic…

…y optional in update security-group
scaleway · Mar 9, 2020 · 0158c03 · 0158c03
1 parent 8d9afd0
commit 0158c03
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-instance-security-group-update-usage.stderr.golden b/cmd/scw/testdata/test-all-usage-instance-security-group-update-usage.stderr.golden
@@ -23,14 +23,14 @@ EXAMPLES:
     scw instance security-group update security-group-id=11111111-1111-1111-1111-111111111111 inbound-default-policy=drop
 
 ARGS:
-  [zone]                             Zone to target. If none is passed will use default zone from the config
-  security-group-id                  ID of the security group to update
-  [name]                             
-  [description]                      
-  [stateful]                         
-  [inbound-default-policy=accept]     (accept | drop)
-  [outbound-default-policy=accept]    (accept | drop)
-  [organization-default]             
+  [zone]                      Zone to target. If none is passed will use default zone from the config
+  security-group-id           ID of the security group to update
+  [name]                      
+  [description]               
+  [stateful]                  
+  [inbound-default-policy]     (accept | drop)
+  [outbound-default-policy]    (accept | drop)
+  [organization-default]      
 
 FLAGS:
   -h, --help   help for update

diff --git a/internal/namespaces/instance/v1/custom_security_group.go b/internal/namespaces/instance/v1/custom_security_group.go
@@ -322,12 +322,10 @@ func securityGroupUpdateCommand() *core.Command {
 			},
 			{
 				Name:       "inbound-default-policy",
-				Default:    core.DefaultValueSetter("accept"),
 				EnumValues: []string{"accept", "drop"},
 			},
 			{
 				Name:       "outbound-default-policy",
-				Default:    core.DefaultValueSetter("accept"),
 				EnumValues: []string{"accept", "drop"},
 			},
 			{