ScalafmtReporter: allow null cause in 3-arg error #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Apr 28, 2022
| @@ -35,7 +35,8 @@ public interface ScalafmtReporter { | |||
| * when the error appeared as a position. | |||
| */ | |||
| default void error(Path file, String message, Throwable e) { | |||
| error(file, new ScalafmtException(message, e)); | |||
| if (e == null) error(file, message); | |||
There was a problem hiding this comment.
Why would we want to have a null Throwable? Isn't it better to create ScalafmtException instead?
There was a problem hiding this comment.
I would like to be able to call error(file, throwable.getMessage, throwable.getCause) and not worry about .getCause returning a null.
There was a problem hiding this comment.
oops, again replied using my alter ego :)
tgodzik
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.