Diff: swap the order of expected-vs-obtained #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was mapping obtained to original, and expected to revised.
tgodzik
approved these changes
Jan 20, 2025
i would emphasize this in the release notes. this particular approach took me a while to get used to, but the last straw was a recent conversation with @bjaglin where i completely misunderstood his bug report where he shared a simple diff between what was checked in and the actual output. |
|
This has subconsciously bugged me for a long time now, but I never thought to suggest it be changed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mapping obtained to original, and expected to revised.