Add support for Scala 3.0.0-M3 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Dec 17, 2020
| def clueImpl[T: Type](value: Expr[T])(using Quotes): Expr[Clue[T]] = { | ||
| import quotes.reflect._ | ||
| val source = Term.of(value).pos.sourceCode.getOrElse("") | ||
| val valueType = TypeTree.of[T].show(using Printer.TreeShortCode) |
There was a problem hiding this comment.
This will print type without the package. This and one line above is the only real change for 3.0.0-M3
larsrh
reviewed
Dec 17, 2020
|
1.15.2 is promoting to Maven Central right now |
mpilquist
reviewed
Dec 17, 2020
tgodzik
force-pushed
the
add-support-for-3.0.0-M3
branch
from
a8d2a71 to
8034155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that scalacheck was wrongly released for 1.5.1, which is not an existing version, so I needed to go around it for now. The issue is tracked under typelevel/scalacheck#732
I also unignored some tests thanks to recent changes for show methods and dropped 0.27.0-RC1