Assert equals doubles #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we have to do the default by hand. If some scaladocs guru knows how to use @see with full method signature to deduplicate the documentation in this case... Good for him!
OlivierBlanvillain
force-pushed
the
assertEquals-doubles
branch
from
bf6de67 to
bdf16b8
Compare
olafurpg
requested changes
Sep 4, 2020
olafurpg
reviewed
Sep 4, 2020
|
My PR was nonsense since both I'm not so sure about the usefulness of last commit, is this what you meant? Also I'll be completely offline for the next ~10 days, but if the PR needs more work I promise I will come back to it afterwards 🙏 |
olafurpg
reviewed
Sep 8, 2020
olafurpg
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
LGTM 👍 Thank you @OlivierBlanvillain
I pushed a commit to remove the framework suite. Framework suites are only helpful if you want to assert the failure message
|
I triggered a 0.7.13 release with this fix https://github.com/scalameta/munit/releases/tag/v0.7.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.