Fix #138 - duplicate names with bracket characters #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in the JUnit/sbt event handler made it ignore tests when two tests had the same name AND the name contains a `[` character. This bug is a relic from the original sbt/junit-interface implementation that assumes that test names are JVM method names where `[` has special meaning. This bug was not present in the Scala.js implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the JUnit/sbt event handler made it ignore tests when two tests
had the same name AND the name contains a
[character. This bug is arelic from the original sbt/junit-interface implementation that assumes
that test names are JVM method names where
[has special meaning.This bug was not present in the Scala.js implementation.