Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringBuilder in AnsiColors #109

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Use StringBuilder in AnsiColors #109

merged 3 commits into from
Apr 20, 2020

Conversation

jvican
Copy link
Contributor

@jvican jvican commented Apr 20, 2020

Fixes #108

@jvican
Copy link
Contributor Author

jvican commented Apr 20, 2020

I confirm this PR fixes #108. I'm not sure how I could reproduce this bug because the inputs for assertNoDiff are quite esoteric (lots of characters, base64, weird encodings, etc) and I can't share them. If you have an idea for a test, let me know @olafurpg

Sorry for not submitting a PR from my fork, I realized I was pushing to the munit repository too late

olafurpg
olafurpg approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for tracking this down!

@olafurpg
Copy link
Member

I pushed one commit just to make it closer to a line-by-line translation of

munit/junit-interface/src/main/java/munit/internal/junitinterface/Ansi.java

Line 31 in 53e8379

public static String filterAnsi(String s)

@olafurpg olafurpg merged commit f61429f into master Apr 20, 2020
@olafurpg olafurpg deleted the ticket/108 branch April 20, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected blocked test execution
2 participants
@jvican @olafurpg