fail the entire suite in case of a fatal exception

scalameta · Aug 28, 2023 · 9cc9c36 · 9cc9c36
1 parent becac1c
commit 9cc9c36
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/munit/shared/src/main/scala/munit/MUnitRunner.scala b/munit/shared/src/main/scala/munit/MUnitRunner.scala
@@ -311,6 +311,7 @@ class MUnitRunner(val cls: Class[_ <: Suite], newInstance: () => Suite)
       case ex: StackOverflowError =>
         handleNonFatalOrStackOverflow(ex)
       case ex =>
+        suiteAborted = true
         notifier.fireTestFailure(new Failure(description, ex))
         Future.successful(())
     }

diff --git a/tests/shared/src/main/scala/munit/SwallowedExceptionSuite.scala b/tests/shared/src/main/scala/munit/SwallowedExceptionSuite.scala
@@ -10,11 +10,16 @@ class SwallowedExceptionSuite extends FunSuite {
   test("issue-650") {
     throw new IllegalAccessError("i am reported")
   }
+
+  test("should not be executed") {
+    assertEquals(1, 1)
+  }
 }
 object SwallowedExceptionSuite
     extends FrameworkTest(
       classOf[SwallowedExceptionSuite],
       """|==> failure munit.SwallowedExceptionSuite.issue-51 - i am not reported
          |==> failure munit.SwallowedExceptionSuite.issue-650 - i am reported
+         |==> skipped munit.SwallowedExceptionSuite.should not be executed - Suite has been aborted
          |""".stripMargin
     )