fix intercept for AssertionError

When trying to `intercept`and `AssertionError` till now the test passed successfully. This fix treats the FailException special.
scalameta · Apr 16, 2024 · 3c59ad1 · 3c59ad1
1 parent ec2ee68
commit 3c59ad1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/munit/shared/src/main/scala/munit/Assertions.scala b/munit/shared/src/main/scala/munit/Assertions.scala
@@ -189,14 +189,15 @@ trait Assertions extends MacroCompat.CompileErrorMacro {
       expectedExceptionMessage: Option[String],
       body: => Any
   )(implicit T: ClassTag[T], loc: Location): T = {
+    val expectedExceptionMsg =
+      s"expected exception of type '${T.runtimeClass.getName()}' but body evaluated successfully"
     try {
       body
-      fail(
-        s"expected exception of type '${T.runtimeClass.getName()}' but body evaluated successfully"
-      )
+      fail(expectedExceptionMsg)
     } catch {
       case e: FailExceptionLike[_]
-          if !T.runtimeClass.isAssignableFrom(e.getClass()) =>
+          if !T.runtimeClass.isAssignableFrom(e.getClass()) ||
+            e.getMessage.contains(expectedExceptionMsg) =>
         throw e
       case NonFatal(e) =>
         if (T.runtimeClass.isAssignableFrom(e.getClass())) {

diff --git a/tests/shared/src/test/scala/munit/FailExceptionSuite.scala b/tests/shared/src/test/scala/munit/FailExceptionSuite.scala
@@ -7,4 +7,19 @@ class FailExceptionSuite extends BaseSuite {
     }
     assert(clue(e).isInstanceOf[Serializable])
   }
+
+  test("assertion-error no exception") {
+    try {
+      intercept[AssertionError] {
+        println("throwing no exception!")
+      }
+    } catch {
+      case e: FailException =>
+        assert(
+          e.getMessage.contains(
+            "expected exception of type 'java.lang.AssertionError' but body evaluated successfully"
+          )
+        )
+    }
+  }
 }