Update fansi to 0.4.0 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fansi dependency is not shaded so this is a small binary incompatible change. Without updating scalafmt-core has a binary compatiblity issue since it depends on sourcecode `0.3.0` through scalameta `trees` and on sourcecode `0.2.7` through fansi `0.3.0`. Updating fansi fixes this incompatibility.
|
Looks like we should also bump Scala JS, we haven't kept the repo up to date much 🤔 |
|
@tgodzik can you approve the pipeline again? |
Done! Though it seems now to be failing on native :/ Most likely a bump is needed there too |
|
Looks like it's almost done! We just need to pin the version on the windows runner to "windows-2019" to make the native tests pass. |
|
It's finally green! Thanks for the patience to approve all the workflows 😄. |
tgodzik
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fansi dependency is not shaded so this is a small binary incompatible change. Without updating scalafmt-core has a binary compatiblity issue since it depends on sourcecode
0.3.0through scalametatreesand on sourcecode0.2.7through fansi0.3.0. Updating fansi fixes this incompatibility.