[Scala 3] Fix indentation in generated code #566
Merged
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
reviewed
Oct 4, 2021
| @@ -51,6 +51,24 @@ class WorksheetSuite extends BaseSuite { | |||
| |""".stripMargin | |||
| ) | |||
|
|
|||
| checkDecorations( | |||
There was a problem hiding this comment.
As this is not just a worksheet issue (it can be reproduced by vanilla mdoc), would you mind adding a test to the regular suites?
There was a problem hiding this comment.
I added the test case to DefaultSuite.scala, seems to work alright.
keynmol
reviewed
Oct 4, 2021
| body.linesIterator.toArray.foreach(this.println) | ||
| if(nest) nestCount -= 1 |
There was a problem hiding this comment.
For my own mental note - will need to keep that in mind when doing #498, to make sure that generated definition is wrapped in {} on scala 2, as indentation alone won't cut it.
tgodzik
force-pushed
the
fix-indentation
branch
from
e214361 to
482edc2
Compare
Previously, we would not add an additional nesting for expressions with generated defintion, which could cause the binder statement to be included in the evaluated statement. Now, we correctly indent after `=` for generated definitions. Fixes scalameta#565
tgodzik
force-pushed
the
fix-indentation
branch
from
482edc2 to
82d8b89
Compare
keynmol
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would not add an additional nesting for expressions with generated defintion, which could cause the binder statement to be included in the evaluated statement.
Now, we correctly indent after
=for generated definitions.Fixes #565