This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Actually make the enable-upload key optional
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Fastpass would fail to read the cache configuration if the `enable-upload` key was not set in the configuration JSON. The intended behavior, and the behavior with this patch, is to make this key optional. It defaults to false unless there are credentials available for the configured cache host.
Previously, the remote cache URL included parts that should be configurable. Also, the artifact would wrongly be named "<filename>.gz", even though we use XZ for compression rather than GZIP now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Fastpass would fail to read the cache configuration if the
enable-uploadkey was not set in the configuration JSON.The intended behavior, and the behavior with this patch, is to make this
key optional. It defaults to false unless there are credentials
available for the configured cache host.