Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

Actually make the enable-upload key optional #85

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

Duhemm
Copy link
Collaborator

@Duhemm Duhemm commented Jun 8, 2022

Previously, Fastpass would fail to read the cache configuration if the
enable-upload key was not set in the configuration JSON.

The intended behavior, and the behavior with this patch, is to make this
key optional. It defaults to false unless there are credentials
available for the configured cache host.

Duhemm added 2 commits June 8, 2022 10:59
Previously, Fastpass would fail to read the cache configuration if the
`enable-upload` key was not set in the configuration JSON.

The intended behavior, and the behavior with this patch, is to make this
key optional. It defaults to false unless there are credentials
available for the configured cache host.
Previously, the remote cache URL included parts that should be
configurable. Also, the artifact would wrongly be named "<filename>.gz",
even though we use XZ for compression rather than GZIP now.
@Duhemm Duhemm merged commit b9dbd86 into scalameta:master Jun 8, 2022
@Duhemm Duhemm deleted the enable-upload-opt branch June 8, 2022 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant