This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Handle base directory conflicts between targets #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Fastpass would not take special considerations when 2 or more targets shared the same base directory. Unfortunately, IntelliJ currently does not allow multiple targets to share the same base directory. As a result, some targets may end up being hidden, source files may be associated with the wrong target, etc. With this patch, Fastpass will try to rebase targets with conflicting base directories where possible. To do so, Fastpass looks at the sources of the targets, and if they share a common root that is not yet the base directory of another target, then Fastpass will use that common root as the new target's base directory. When the conflict cannot be automatically resolved, Fastpass shows a warning message.
mikkoziel
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Fastpass would not take special considerations when 2 or
more targets shared the same base directory. Unfortunately, IntelliJ
currently does not allow multiple targets to share the same base
directory. As a result, some targets may end up being hidden, source
files may be associated with the wrong target, etc.
With this patch, Fastpass will try to rebase targets with conflicting
base directories where possible. To do so, Fastpass looks at the sources
of the targets, and if they share a common root that is not yet the base
directory of another target, then Fastpass will use that common root as
the new target's base directory.
When the conflict cannot be automatically resolved, Fastpass shows a
warning message.