Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error message when SemanticDB scalac plugin can't be found #467

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

danicheg
Copy link
Contributor

Hey there! Recently, I've been upgrading some dependencies of one project and accidentally got this error message in SBT:

The SemanticDB scalac plugin version 4.9.3 set up via semanticdbVersion does follow the version recommended for Scalafix, but is not supported for the outdated Scala version 2.13.16. Please upgrade to a more recent Scala patch version or uninstall sbt-scalafix.

Honestly, it's a bit confusing since Scala 2.13.16 is the most recent version of the 2.13 series. What I actually had to do was update the sbt-scalafix version to the latest one.

So, here's the enhancement of that error message.

@danicheg
Copy link
Contributor Author

@bjaglin

Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, that message added in #369 was really to cover the combination of a recent sbt-scalafix with an old scala version, but I didn't realize some users could be on an old sbt-scalafix with a recent scala version.

Thanks for taking the time to report back and make the error message more actionable!

@bjaglin bjaglin changed the title Enhance the error message for the update command Enhance error message when SemanticDB scalac plugin can't be found Feb 16, 2025
@bjaglin
Copy link
Collaborator

bjaglin commented Feb 16, 2025

CI doesn't run automatically for first-time contributors, I just kicked it off. Could you update

"Please upgrade to a more recent Scala patch version or uninstall sbt-scalafix"
?

@danicheg
Copy link
Contributor Author

@bjaglin Thank you for your assistance!

@bjaglin bjaglin merged commit 037b18d into scalacenter:main Feb 16, 2025
7 checks passed
@danicheg danicheg deleted the tweak-error-msg branch February 17, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants