test on JDK23 #462
Merged
test on JDK23 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
jdk23
branch
4 times, most recently
from
4fa6a45 to
d5eeeca
Compare
bjaglin
commented
Jan 31, 2025
| @@ -78,7 +78,7 @@ class ScalafixAPISuite extends AnyFunSuite { | |||
| ) | |||
| ) | |||
| val obtainedError = mainInterface.run().toList | |||
| val out = fansi.Str(baos.toString()).plainText | |||
| val out = fansi.Str(baos.toString(), fansi.ErrorMode.Strip).plainText | |||
There was a problem hiding this comment.
[info] - ScalafixPlugin.cli *** FAILED ***
[info] java.lang.IllegalArgumentException: Unknown ansi-escape [0J at index 132 inside string cannot be parsed into an fansi.Str
[info] at fansi.ErrorMode$Throw$.handle(Fansi.scala:440)
[info] at fansi.ErrorMode$Throw$.handle(Fansi.scala:428)
[info] at fansi.Str$.apply(Fansi.scala:280)
[info] at scalafix.internal.sbt.ScalafixAPISuite.$anonfun$new$1(ScalafixAPISuite.scala:82)
[info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
Silence "Unknown ansi-escape [0J at index 132" seen with JDK23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalacenter/scalafix#2075 was not needed apparently because we don't exercise reading bytecode from the JRE here, unlike scalafix that does and was generating