caching: don't forget previous invocations #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the most annoying caching shortcoming described in scalacenter/scalafix#1164 and discussed in https://gitter.im/scalacenter/scalafix?at=5ea6b3b43d7e50071c34fd67 (1).
This allows cache accumulation after successive runs of scalafix with different rules, which is common as it's currently the only
way to safely run several semantic rules in order.
Note that the cache remains incremental only for files, so if a file is stale for a single rule, all rules will be executed on this file.
Example on a real project
Stamping before
Stamping after