Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow permissions error when opening source file #22639

Closed
wants to merge 1 commit into from

Conversation

som-snytt
Copy link
Contributor

Follow-up to #21633

Push the exception handling down a level and propagate AccessDeniedException.

The compiler silently compiles empty compilation units, so hiding all other exceptions results in silence.

Could be user-friendly to issue diagnostic messages.

@som-snytt
Copy link
Contributor Author

The test claims it didn't throw AccessDenied. That is Ubuntu and JDK 17. Amazingly, it's Windows that passed. Of course tests pass locally (WSL 2).

I'm not highly motivated to futz with file system-sensitive tests, so I will close this one. It's more of a nice-to-have.

@som-snytt som-snytt closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant