Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve hard unions in widenSingletons #22369

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Preserve hard unions in widenSingletons #22369

merged 1 commit into from
Jan 15, 2025

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Jan 14, 2025 •
edited
Loading

Fixes #22219.

@noti0na1
Copy link
Member

Can you check the test from #19907 to ensure them are not slow?

@mbovel
Copy link
Member Author

mbovel commented Jan 15, 2025

On my machine, both i19907_slow_1000_3.scala and i19907_slow_1000_4.scala compile in 3 seconds, both before and after the change in this PR.

@mbovel mbovel requested a review from noti0na1 January 15, 2025 09:08
noti0na1
noti0na1 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noti0na1 noti0na1 merged commit 0fe6877 into scala:main Jan 15, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@noti0na1 noti0na1 noti0na1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Union of literal types is not inferred correctly
3 participants
@mbovel @noti0na1 @dwijnand