Backport "Fix a REPL bad symbolic reference" to LTS #20939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xLiteral mistakenly assumed that the element just after `<` is always non-special element, but it is not true. It could be xCharData, comment, xProcInstr. [Cherry-picked 77aa363]
Just replacing element with content_LT, it works. See #19522 (comment) [Cherry-picked 27046fe]
To check parsing properly, it is better to run a test and assert parse result. [Cherry-picked 9de9d57]
[Cherry-picked 3c453ab][modified]
[Cherry-picked cc69895]
…g keyword [Cherry-picked 300f2cc]
[Cherry-picked 5e0dfba]
[Cherry-picked e6b8e75]
it only adds to the confusion about asInstanceOf introducing type checks. See https://contributors.scala-lang.org/t/this-trick-enables-overloading-for-opaque-types/6560/17 and https://contributors.scala-lang.org/t/pre-sip-deprecate-asinstanceof-introduce-unsafeasinstanceof/6568 [Cherry-picked 5212897]
Backports changes from Metals: scalameta/metals#5983 [Cherry-picked be8abfa]
[Cherry-picked 3e2a88e]
[Cherry-picked b3501a6]
potential TODO: tree's of Raw types from Java are still incorrect once they are serialized to TASTy, however it is debateable if we care to support them. [Cherry-picked 3ab2999]
[Cherry-picked e8e295a][modified]
(If we widen Foo.this.Inner in the parents of a class to AbstractFoo#Inner, i.e. an inherited class Inner prefixed by its owner abstract class AbstractFoo, this is not considered a stable prefix for a class parent type. But in Java this is the correct type so allow it.) [Cherry-picked d37857c]
[Cherry-picked faf8547]
Add a test to confirm issue#19762 is solved. [Cherry-picked 2a1d1b3]
(not only `using` params) [Cherry-picked 1e89016]
[Cherry-picked 2e684d8]
Given a query as
```scala
def func(a@@: Int, b: Int)(c: Int) =
a + b + c
```
range selection will now let you choose `a: Int, b: Int`.
The previous options are `a: Int` and the whole definition of `func`.
[Cherry-picked 9f61ed5]
[Cherry-picked 6db1423]
[Cherry-picked c2c78d7]
[Cherry-picked 4615a9c]
- Be more specific when we go into the special case of not updating checkedPeriod - Always update lastDenotation. - Keep computeDenot small, move work to recomputeDenot [Cherry-picked e79b2e9]
…ario This brings back an element of the original solution. [Cherry-picked 5631d76]
[Cherry-picked 46c50e7]
|
Backport temporarily suspended as it causes a new regressions in the OpenCB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #19786 to the LTS branch.
PR submitted by the release tooling.
[skip ci]