Backport to fix a REPL bad symbolic reference #19756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odersky see my comment at #15562 (comment), any suggestions on how we can fix this within the denotation update logic? |
|
Need to pull in the changes in #19786 |
Using issue scala#18650 as the reference (but issue scala#18999 is another option) building on the fix in PR scala#18719 (refined in PR scala#18727) as well as the fix in PR scala#18760, I'm trying to make a more root change here by making sure that message forcing only occurs with `hasErrors`/`errorsReported` is true, so as to avoid assertion errors crashing the compiler. (cherry picked from commit 10f2c10)
dwijnand
force-pushed
the
repl-bad-symbolic-ref
branch
from
8d03e8c to
95377aa
Compare
- Be more specific when we go into the special case of not updating checkedPeriod - Always update lastDenotation. - Keep computeDenot small, move work to recomputeDenot (cherry picked from commit e79b2e9)
…ario This brings back an element of the original solution. (cherry picked from commit 5631d76)
dwijnand
force-pushed
the
repl-bad-symbolic-ref
branch
from
95377aa to
fb18037
Compare
|
@Kordyjan Does CI work on the release-3.3.3 branch? I suspect that all these failures aren't due to the changes here. I could be wrong, but I just wanted to confirm the baseline. |
dwijnand
added
the
backport:nominated
WojciechMazur
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15562