Stabilise @publicInBinary (#22591)

Closes #22497 Before merging this PR, the SIP committee still has to vote the acceptance of the SIP.
scala · Feb 22, 2025 · 4dc4668 · 4dc4668
2 parents 1279286 + 2bd5a47
commit 4dc4668
Show file tree

Hide file tree

Showing 15 changed files with 12 additions and 28 deletions.
diff --git a/library/src/scala/annotation/publicInBinary.scala b/library/src/scala/annotation/publicInBinary.scala
@@ -16,5 +16,4 @@ package scala.annotation
  *  Adding this annotation to a non-public definition can also cause binary incompatibilities
  *  if the definition is accessed in an inline definition (these can be checked using `-WunstableInlineAccessors`).
  */
-@experimental
 final class publicInBinary extends scala.annotation.StaticAnnotation
diff --git a/tests/neg/i22498.check b/tests/neg/i22498.check
@@ -1,4 +1,4 @@
--- Error: tests/neg/i22498.scala:7:32 ----------------------------------------------------------------------------------
-7 |    inline def proxy: Foo = new Foo(0) // error
+-- Error: tests/neg/i22498.scala:5:32 ----------------------------------------------------------------------------------
+5 |    inline def proxy: Foo = new Foo(0) // error
   |                                ^^^
   |                                Private constructors used in inline methods require @publicInBinary
diff --git a/tests/neg/i22498.scala b/tests/neg/i22498.scala
@@ -1,5 +1,3 @@
-//> using options -experimental
-
 import scala.annotation.publicInBinary
 
 class Foo:

diff --git a/tests/neg/inline-unstable-accessors.scala b/tests/neg/inline-unstable-accessors.scala
@@ -1,4 +1,4 @@
-//> using options -experimental -Werror -WunstableInlineAccessors -explain
+//> using options -Werror -WunstableInlineAccessors -explain
 
 package foo
 import scala.annotation.publicInBinary

diff --git a/tests/neg/publicInBinaryOverride.check b/tests/neg/publicInBinaryOverride.check
@@ -1,5 +1,5 @@
--- [E164] Declaration Error: tests/neg/publicInBinaryOverride.scala:10:15 ----------------------------------------------
-10 |  override def f(): Unit = () // error
-   |               ^
-   |               error overriding method f in class A of type (): Unit;
-   |                 method f of type (): Unit also needs to be declared with @publicInBinary
+-- [E164] Declaration Error: tests/neg/publicInBinaryOverride.scala:8:15 -----------------------------------------------
+8 |  override def f(): Unit = () // error
+  |               ^
+  |               error overriding method f in class A of type (): Unit;
+  |                 method f of type (): Unit also needs to be declared with @publicInBinary
diff --git a/tests/neg/publicInBinaryOverride.scala b/tests/neg/publicInBinaryOverride.scala
@@ -1,5 +1,3 @@
-//> using options -experimental
-
 import scala.annotation.publicInBinary
 
 class A:

diff --git a/tests/pos-macros/i15413/Macro_1.scala b/tests/pos-macros/i15413/Macro_1.scala
@@ -1,4 +1,4 @@
-//> using options -experimental -Werror -WunstableInlineAccessors
+//> using options -Werror -WunstableInlineAccessors
 
 import scala.quoted.*
 import scala.annotation.publicInBinary

diff --git a/tests/pos-macros/i15413b/Macro_1.scala b/tests/pos-macros/i15413b/Macro_1.scala
@@ -1,4 +1,4 @@
-//> using options -experimental -Werror -WunstableInlineAccessors
+//> using options -Werror -WunstableInlineAccessors
 
 package bar
 

diff --git a/tests/pos-macros/i19526b/Test.scala b/tests/pos-macros/i19526b/Test.scala
@@ -1,5 +1,3 @@
-//> using options -experimental
-
 package crash.test
 
 case class Stack private[crash] (

diff --git a/tests/run-tasty-inspector/stdlibExperimentalDefinitions.scala b/tests/run-tasty-inspector/stdlibExperimentalDefinitions.scala
@@ -39,9 +39,6 @@ val experimentalDefinitionInLibrary = Set(
   "scala.annotation.into",
   "scala.annotation.internal.$into",
 
-  //// New feature: @publicInBinary
-  "scala.annotation.publicInBinary",
-
   //// New feature: Macro annotations
   "scala.annotation.MacroAnnotation",
 

diff --git a/tests/run/i13215.scala b/tests/run/i13215.scala
@@ -1,4 +1,4 @@
-//> using options -experimental -Werror -WunstableInlineAccessors
+//> using options -Werror -WunstableInlineAccessors
 
 import scala.annotation.publicInBinary
 

diff --git a/tests/run/i22497.scala b/tests/run/i22497.scala
@@ -3,11 +3,9 @@
 import scala.annotation.publicInBinary
 import scala.annotation.experimental
 
-@experimental
 class Foo:
   @publicInBinary private def this(i: Int) = this()
   @publicInBinary protected def this(i: String) = this()
 
-@experimental
 @main def Test =
   println(classOf[Foo].getConstructors().mkString("\n"))
diff --git a/tests/run/i22498.scala b/tests/run/i22498.scala
@@ -1,5 +1,3 @@
-//> using options -experimental
-
 import scala.annotation.publicInBinary
 
 class Foo:

diff --git a/tests/run/noProtectedSuper.scala b/tests/run/noProtectedSuper.scala
@@ -1,5 +1,3 @@
-//> using options -experimental
-
 import scala.annotation.publicInBinary
 
 package p {

diff --git a/tests/run/publicInBinary/Lib_1.scala b/tests/run/publicInBinary/Lib_1.scala
@@ -1,4 +1,4 @@
-//> using options -experimental -Werror -WunstableInlineAccessors
+//> using options -Werror -WunstableInlineAccessors
 
 package foo