Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all Cats JVM projects #375

Merged
merged 3 commits into from
Jan 5, 2017
Merged

Run all Cats JVM projects #375

merged 3 commits into from
Jan 5, 2017

Conversation

adelbertc
Copy link
Contributor

No description provided.

@adelbertc adelbertc mentioned this pull request Oct 28, 2016
Closed
@SethTisue
Copy link
Member

isn't this just going to fail for lack of #13?

@adelbertc
Copy link
Contributor Author

Yep. I saw #371 and incorrectly assumed everything is OK now.

@SethTisue
Copy link
Member

care to rebase and try again now, after #448 ?

@SethTisue SethTisue removed the on hold label Jan 4, 2017
@SethTisue SethTisue mentioned this pull request Jan 4, 2017
Closed
@adelbertc
Copy link
Contributor Author

@SethTisue rebased

@SethTisue SethTisue self-assigned this Jan 5, 2017
@SethTisue
Copy link
Member

test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1148/consoleFull (404 til Jenkins finishes up some other work)

@SethTisue
Copy link
Member

SethTisue commented Jan 5, 2017 •
edited
Loading

[cats] These subprojects will be built: macrosJVM, kernelJVM, coreJVM, kernelLawsJVM, lawsJVM, testsJVM, jvm, freeJVM, docs, bench, catsJVM — we'll need to use extra.exclude to exclude docs and bench

@SethTisue
Copy link
Member

SethTisue commented Jan 5, 2017 •
edited
Loading

yeah, we don't have tut:

[cats] Processing subproject: docs
[cats] [error] **** Missing dependency: the library org.tpolecat#tut-core is not provided (in space "default") by any project in this configuration file.
[cats] [error] In order to control which version is used, please add the corresponding project to the build file
[cats] [error] (or use "check-missing:false" to ignore (not recommended)).
[cats] java.lang.RuntimeException: Required dependency not found

as for bench, not sure if it actually errors, but in general in the community build we prefer to leave benchmarks out

@SethTisue
Copy link
Member

new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1151/consoleFull (404 til Jenkins finishes polishing Eric Torreborre's silver)

@SethTisue
Copy link
Member

hmm

[cats] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[cats] [warn] 	::          UNRESOLVED DEPENDENCIES         ::
[cats] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[cats] [warn] 	:: org.typelevel#cats-bench;0.9.0-dbuildx1e6079055102c537004201ab8985305c310a2e5c: not found
[cats] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::

normally excluding a subproject doesn't do this. not sure if it's dbuild's fault, or it's something weird about the cats build.

I'll fiddle with it

@SethTisue
Copy link
Member

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1153/consoleFull

@SethTisue SethTisue merged commit 95035bf into scala:2.12.x Jan 5, 2017
@dwijnand
Copy link
Member

dwijnand commented Jan 5, 2017

It's possible it didn't work because the dependency on bench is defined as bench % "compile-internal;test-internal -> test".

/cc @cunei who:

  • might be interested, and/or
  • might know already about this/knows that it's true, and/or
  • might know how to make it work the way you want it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adelbertc @SethTisue @dwijnand