-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.11.x failing due to missing spray-json-shapeless dependency for ensime-server #119
Conversation
specs2 failed, because there was a change in shapeless that changed It seems you need to update specs2 to include etorreborre/specs2@0b08208
|
4408740
to
a2a35c2
Compare
ensime requires spray-shapeless-json; spray-shapeless-json requires a newer Shapeless than we were using; specs2 doesn't work with that new Shapeless, so we upgrade it; the new specs2 requires scalaz-stream; scalaz-stream requires scodec-bits; the scodec-bits build uses jmh-plugin which requires JDK 7+, so we must use a fork with the plugin removed; and a partridge in a pear tree.
to see if it makes this error go away: java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: scala/runtime/java8/JFunction1
the changes in Adriaan's fork had to do with sbt plugins, which we are now using binary dependencies for instead of building from source, so maybe the fork isn't needed. also, scalariform has a new maintainer
This reverts commit 57ac8fa.
and because 7.2 is bleeding edge anyway, 7.1 is a better stable version to be using
for 2.11.x, this was resolved by #126 simply by not upgrading ENSIME. I plan to revisit this (am already revisiting it, on a wip branch) in the context of 2.11.x-jdk8. 2.11.x(jdk6) is more legacy at this point, more something we're content to freeze versions in. |
improvements to this are in #147 |
https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-community-build/49/console shows the failure:
the cause is https://github.com/ensime/ensime-server/commit/88cd6e33e946c472e1a1c3477942425211ac6974
perhaps it will be straightforward to just add the dependency? we'll see. spray-json-shapeless's dependencies are here: https://github.com/fommil/spray-json-shapeless/blob/master/build.sbt