Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maximum Pull Request length configurable #3572

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

mzuehlke
Copy link
Member

@mzuehlke mzuehlke commented Feb 1, 2025

Depending on the used forge the size of the description of a Pull Request differs. With the additional metadata this limit can be easily exceeded.

This Pull Request sets the allowed length to:

  • global default: 65536
  • Azure: 4000
  • BitbucketServer: 32768

Closes: #3543

Depending on the used forge the size of the description of a Pull Request differs.
With the additional metadata this limit can be easily exceeded.

This Pull Request sets the allowed length to:
* global default: 65536
* Azure: 4000
* BitbucketServer: 32768

Closes: #3543
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (3f58890) to head (4ae99ff).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
+ Coverage   89.79%   89.80%   +0.01%     
==========================================
  Files         174      174              
  Lines        5029     5034       +5     
  Branches      491      494       +3     
==========================================
+ Hits         4516     4521       +5     
  Misses        513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzuehlke mzuehlke merged commit 876f4fb into main Feb 3, 2025
18 checks passed
@mzuehlke mzuehlke deleted the pr-length-per-forge branch February 3, 2025 09:18
@mzuehlke mzuehlke added this to the 0.33.0 milestone Feb 3, 2025
@mzuehlke mzuehlke added enhancement New feature or request cat:forge labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:forge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRs brake Azure Devops PR Description 4000 characters limit
2 participants