Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary Scalafix migration for Cats 2.2.0 #1588

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Sep 1, 2020

This adds @cb372's Scalafix for Cats 2.2.0 from typelevel/cats#3566. Once that PR is merged, we should update the rewriteRules so that it points to the official Cats repo. Using 2.2.0-RC4 as newVersion allows us to test this migration before the final release. To do so just bump Cats to 2.2.0-RC3 and let Scala Steward do the update to 2.2.0-RC4 with this migration applied.

@fthomas fthomas added this to the 0.7.0 milestone Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1588 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1588      +/-   ##
==========================================
+ Coverage   70.22%   70.28%   +0.05%     
==========================================
  Files         113      113              
  Lines        1780     1780              
  Branches       48       48              
==========================================
+ Hits         1250     1251       +1     
+ Misses        530      529       -1     
Impacted Files Coverage Δ
.../org/scalasteward/core/scalafix/MigrationAlg.scala 100.00% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb29255...56370c8. Read the comment docs.

@fthomas fthomas merged commit 049f500 into master Sep 1, 2020
fthomas added a commit to fthomas/scalafix-test that referenced this pull request Sep 1, 2020
For testing the Cats 2.2.0 Scalafix migration: scala-steward-org/scala-steward#1588
@fthomas fthomas deleted the topic/scalafix-cats-2.2.0 branch September 2, 2020 09:07
@fthomas fthomas mentioned this pull request Sep 2, 2020
12 tasks
fthomas added a commit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant