Test of the Scalafix migration for Cats 2.2.0

[fthomas]

This is a test of the Scalafix migration for Cats 2.2.0 (typelevel/cats#3566). Before this change, Cats was a transitive dependency of other dependencies so I added cats-core as dependency explicitly. I then added a scalafix-conf.sbt which contains the scalacOptions += "-P:semanticdb:synthetics:on" (as per https://github.com/typelevel/cats/pull/3566/files#diff-c131653cee48b25eb56e8856605a9370). Then I ran scalafixEnable and scalafix github:cb372/cats/Cats_v2_2_0?sha=235bd7c92e431ab1902db174cf4665b05e08f2f1 in a sbt shell.

All cats.implicits._ imports are gone but unfortunately the build failed with more than 200 errors. The first three errors are:

[info] Compiling 1 Scala source to /home/travis/build/scala-steward-org/scala-steward/modules/sbt-plugin/.jvm/target/scala-2.12/sbt-1.0/classes ...
[error] /home/travis/build/scala-steward-org/scala-steward/modules/core/src/main/scala/org/scalasteward/core/application/Cli.scala:78:32: value leftMap is not a member of Either[Throwable,scala.concurrent.duration.FiniteDuration]
[error]         parseFiniteDuration(s).leftMap { throwable =>
[error]                                ^
[error] /home/travis/build/scala-steward-org/scala-steward/modules/core/src/main/scala/org/scalasteward/core/application/Cli.scala:85:12: value catchNonFatal is not a member of object scala.util.Either
[error]     Either.catchNonFatal(Duration(s)).flatMap {
[error]            ^
[error] /home/travis/build/scala-steward-org/scala-steward/modules/core/src/main/scala/org/scalasteward/core/application/Cli.scala:93:30: value leftMap is not a member of org.http4s.ParseResult[org.http4s.Uri]
[error]       s => Uri.fromString(s).leftMap(pf => MalformedValue("Uri", pf.message))
[error]                              ^

It seems that adding import cats.syntax.all._ to that file fixes these errors. I've no idea why the migration didn't add them automatically.

[codecov]

Codecov Report

Merging #1582 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1582   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         113      113           
  Lines        1786     1786           
  Branches       51       51           
=======================================
  Hits         1255     1255           
  Misses        531      531           

Impacted Files	Coverage Δ
.../scala/org/scalasteward/core/application/Cli.scala	93.75% <ø> (ø)
...g/scalasteward/core/application/SelfCheckAlg.scala	0.00% <ø> (ø)
...org/scalasteward/core/application/StewardAlg.scala	0.00% <ø> (ø)
...g/scalasteward/core/application/SupportedVCS.scala	46.15% <ø> (ø)
.../core/bitbucket/http4s/Http4sBitbucketApiAlg.scala	96.55% <ø> (ø)
...ard/core/bitbucket/http4s/RepositoryResponse.scala	91.30% <ø> (ø)
...steward/core/bitbucket/http4s/authentication.scala	0.00% <ø> (ø)
...ketserver/http4s/Http4sBitbucketServerApiAlg.scala	0.00% <ø> (ø)
...lasteward/core/buildtool/BuildToolDispatcher.scala	81.81% <ø> (ø)
...g/scalasteward/core/buildtool/maven/MavenAlg.scala	84.61% <ø> (ø)
... and 54 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33249b1...216832a. Read the comment docs.