Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options section error #13

Closed
idarlington opened this issue Jun 16, 2016 · 4 comments
Closed

Options section error #13

idarlington opened this issue Jun 16, 2016 · 4 comments
Labels
enhancement New feature or request

Comments

@idarlington
Copy link
Contributor

idarlington commented Jun 16, 2016

Hi,

def matchOptions(res0: Float, res1: Float) {
    val someValue: Option[Double] = Some(20.0)
    val value = someValue match {
      case Some(v)  v
      case None     0.0
    }
    value should be(res0)
    val noValue: Option[Double] = None
    val value1 = noValue match {
      case Some(v)  v
      case None     0.0
    }
    value1 should be(res1)
  }

The above test in the options exercise throws an error because the test is comparing a Float to a Double value1 should be(res1) and most persons input their answers as Double.

I could put in a pull request.

@idarlington idarlington changed the title options section error Options section error Jun 16, 2016
@raulraja
Copy link
Member

@idarlington makes sense. Would love to see a PR thanks!

@raulraja raulraja added the enhancement New feature or request label Jun 17, 2016
@idarlington
Copy link
Contributor Author

Hi @raulraja what is the PR process like.

@raulraja
Copy link
Member

@idarlington Just fork this repo, make any changes in your repo, push and send a PR back when ready. We can give you push access down the road if you plan on contributing more. Thanks!

@idarlington
Copy link
Contributor Author

@raulraja I have done that. Thanks.

I am also interested in contributing more moving forward.

raulraja added a commit that referenced this issue Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants