Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DLL not found on Windows #233

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Fix DLL not found on Windows #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/src/main/scala/com/github/sbt/jni/build/Cargo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class Cargo(protected val configuration: Seq[String]) extends BuildTool {

val subdir = if (release) "release" else "debug"
val products: List[File] =
(targetDirectory / subdir * ("*.so" | "*.dylib")).get().filter(_.isFile).toList
(targetDirectory / subdir * ("*.so" | "*.dylib" | "*.dll")).get().filter(_.isFile).toList

validate(products, multipleOutputs, logger)
}
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/main/scala/com/github/sbt/jni/build/ConfigureMakeInstall.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ trait ConfigureMakeInstall { self: BuildTool =>
if (ev != 0) sys.error(s"Building native library failed. Exit code: ${ev}")

val products: List[File] =
(targetDirectory ** ("*.so" | "*.dylib")).get.filter(_.isFile).toList
(targetDirectory ** ("*.so" | "*.dylib" | "*.dll")).get.filter(_.isFile).toList

validate(products, multipleOutputs, log)
}
Expand Down
Loading