Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance 2025 #192

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .eslintrc.json

This file was deleted.

8 changes: 4 additions & 4 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
name: Test and lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
# with:
# node-version: '14'
- uses: actions/checkout@v2
# node-version: '22'
- uses: actions/checkout@v4
- run: |
npm install
npm ci
npm run test
npm run lint
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ jspm_packages

# artifacts
coverage
dist
build

# Serverless directories
.serverless
Expand Down
21 changes: 21 additions & 0 deletions TODO
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
Maintenance:
☐ switch to `nodejs22.x`
☐ add bundler ( `@vercel/ncc` ? or `vite` or `esbuild` inside serverless)
☐ update serverless
☐ switch config to abap-version-shield.sbcg.com.ua (+ certificate)
☐ add `version` or `about` endpoint (name, version, web-url)

Update dependencies:
✘ The querystring API is considered Legacy. new code should use the URLSearchParams API instead @cancelled(25-01-18 20:23)
✘ Upgrade to v7.0.2+ of superagent @cancelled(25-01-18 20:23)

Updates:
✔ Upgrade to esm @done(25-01-18 20:22)
✔ Switch to vitest @done(25-01-18 20:22)
☐ Maybe switch to TS + vite (or esbuild)
☐ remove root path (version-shield-json)
☐ But keep version-shield-json as a redirect
☐ support VERSION_CONSTANT in abapgit json

Stopped at 25-01-18:
- trying to node_modules/.bin/sls package -> require IAM rights changes ... review sls docs
10 changes: 7 additions & 3 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ Legend
+ : added
- : removed

Important dev notes
-------------------
- node-fetch bind to version @2 due to ESM only support in version 3
v1.1.0, 2025-01-??
------------------
! move to abap-version-shield.sbcg.com.ua domain
! migrate to ESM
! migrate to vitest
! upgrade all packages
! remove version-shield-json prefix

v1.0.3, 2022-03-21
------------------
Expand Down
2 changes: 1 addition & 1 deletion dev-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
## Useful
- `serverless package` - check what will be in zip package (built in .serverless dir)

## redirect
## Redirect
- https://alestic.com/2015/11/amazon-api-gateway-aws-cli-redirect/
- https://medium.com/@lakshmanLD/lambda-proxy-vs-lambda-integration-in-aws-api-gateway-3a9397af0e6d
- https://github.com/jnupponen/apigw-redirect/blob/master/template.yaml
Expand Down
21 changes: 21 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import globals from 'globals';
import pluginJs from '@eslint/js';

export default [
pluginJs.configs.recommended,
{
files: ["src/**/*.js"],
languageOptions: {
globals: {
...globals.node,
},
},
rules: {
"quotes": ["error", "single", { "avoidEscape": true }],
"semi": ["error", "always", { "omitLastInOneLineBlock": true}],
"no-console": "off",
"no-trailing-spaces": ["error"],
"indent": ["error", 4, { "SwitchCase": 1 }]
}
}
];
Loading
Loading