Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform specific index files #2

Closed

Conversation

Infoto
Copy link

@Infoto Infoto commented Apr 17, 2020

The method declarations in index.js were empty,
therefore I had to import it from either .ios or .android
which is not that convenient.
Fixes issue corbt#74.

The method declarations in index.js were empty,
therefore I had to import it from either .ios or .android
which is not that convenient.
Fixes issue corbt#74.
@sayem314
Copy link
Owner

index.platform.js should be handled properly by react-native. without platform-specific code, this module breaks on web and desktop.

@sayem314 sayem314 added the invalid This doesn't seem right label Apr 18, 2020
@sayem314
Copy link
Owner

Your project is broken somehow, maybe open an issue on react-native about not selecting platform-specific extension and in the meantime, you can use either index.ios or index.android on both platforms because they share the same code.

@sayem314 sayem314 closed this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants