Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from eval() #28

Open
winstliu opened this issue Dec 18, 2015 · 0 comments
Open

Move away from eval() #28

winstliu opened this issue Dec 18, 2015 · 0 comments
Assignees
@winstliu
Labels
enhancement performance

Comments

@winstliu
Copy link
Collaborator

eval prevents its entire containing function from being optimized, not to mention that pretty much every linter and Javascript guide out there doesn't recommend it.

The plan is to switch everything to math.eval instead, which despite its name does not seem to call eval internally. This will also speed up the graphing process even more since it'll allow the addBSP and addSolidWithoutHoles functions to be optimized.

This is considerably trickier than the previous switch because the eval'd code contains actual Javascript code and not just math like the equations and bounds.
@winstliu winstliu self-assigned this Dec 19, 2015
winstliu added a commit that referenced this issue Dec 19, 2015
@winstliu
Initial conversion from eval to math.eval
b47fa5e 
Closes #28

Still need to compile the equations and then measure performance, but
this is a great first step :)
@winstliu winstliu mentioned this issue Dec 19, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winstliu winstliu

Labels
enhancement performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@winstliu