-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different xml output since wasabi 3.6 update #99
Comments
Appreciate the digging! Wasabi does a wrong thing to create "Ruby hash representation", instead of XML, here:
I marked this as a Bug report. |
this is also stopping us from updating to version 3.6. |
This change breaks backwards compatibility, by changing the parsing of the SOAP messages. I do not know if the change is incorrect. But if introduced, according to SemVer it must be introduced in a new major release, to give downstreams the chance to port their code accordingly. Fixes savonrb#99 See also savonrb/savon#935 This reverts commit 6fc97c6.
I also struggled with this for some time as part of the savon gem. Have added wasabi to our gemfile now and locked it to 3.5.0. |
This change breaks backwards compatibility, by changing the parsing of the SOAP messages. Fixes #99 See also savonrb/savon#935 This reverts commit 6fc97c6.
Thank you for your time and this gem.
We are using the wasabi (3.6.1) gem via the savon (2.12.1) gem.
With wasabi 3.6.1 we get a different xml output.
wasabi 3.5.0
wasabi 3.6.1
If we remove this block the XML is like the XML from wasabi 3.5.0.
https://github.com/savonrb/wasabi/compare/v3.5.0..v3.6.1#diff-7c3adc3042c46c5df567b221e60c3442R285
This block comes from this commit:
8b18d4e
The .wsdl File looks like this:
Is there a Problem with the .wsdl File or the commit or savon?
Thank you in advance.
The text was updated successfully, but these errors were encountered: