Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Feature. This makes logging request and response headers optional
Did you add tests for your changes?
Added unit tests for
options_spec
Summary of changes
Motivation: Savon log headers which contain
Authorization
header most of the time and I think it will be better for more security to hide this header from logs or at least add an option to give the developer the freedom to log it or not.Changes: I did that by adding
log_headers
option to theGlobalOptions
class and giving it a default valuetrue
, so the current users won't be affected.Other information