Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_headers option to globals #931

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

EslamMoh
Copy link
Contributor

@EslamMoh EslamMoh commented Aug 5, 2020

What kind of change is this?

Feature. This makes logging request and response headers optional

Did you add tests for your changes?

Added unit tests for options_spec

Summary of changes

Motivation: Savon log headers which contain Authorization header most of the time and I think it will be better for more security to hide this header from logs or at least add an option to give the developer the freedom to log it or not.

Changes: I did that by adding log_headers option to the GlobalOptions class and giving it a default value true, so the current users won't be affected.

Other information

@EslamMoh EslamMoh changed the title Add log headers option to globals Add log_headers option to globals Aug 5, 2020
@pcai pcai merged commit b0926be into savonrb:master Aug 4, 2022
@pcai
Copy link
Member

pcai commented Aug 4, 2022

@EslamMoh thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants