Add support for rpc encoded wsdl #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Wasabi add support for multi part on messages, now it's returning a hash with parts, and Savon needs to handle correctly. So on builder, instead of just add a single message to body, now handle if it's a hash and build the body containing the respective parts, with its type and arguments passed via `locals` variable. This way we add support for builder create a message that contains multi parts.
|
build is broken because it's using wasabi latest release that do not include rcp/encoded support |
tjarratt
added a commit
that referenced
this pull request
Mar 4, 2016
…coded Add support for rpc encoded wsdl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Wasabi add support for multi part on messages, now it's returning a hash
with parts, and Savon needs to handle correctly.
So on builder, instead of just add a single message to body, now handle if it's
a hash and build the body containing the respective parts, with its type and
arguments passed via
localsvariable.This way we add support for builder create a message that contains multi parts.
check: savonrb/wasabi#63 for wasabi support on
rpc/encoded wsdl.
disclaimer: I'm totally new to SOAP, sorry if I misunderstood any concept.
I tried to implement touch as few places as possible on current code base.