Added ssl_ca_path and ssl_cert_store to client global options #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checkout savonrb/httpi#165 |
| @@ -94,4 +96,4 @@ def configure_headers(soap_action) | |||
| @http_request.headers["Content-Type"] ||= CONTENT_TYPE[@globals[:soap_version]] % @globals[:encoding] | |||
| end | |||
| end | |||
| end | |||
| end | |||
There was a problem hiding this comment.
Don't remove the file-ending newline.
| @@ -1051,5 +1071,4 @@ def inspect_request(response) | |||
| hash = JSON.parse(response.http.body) | |||
| OpenStruct.new(hash) | |||
| end | |||
|
|
|||
| end | |||
| end | |||
There was a problem hiding this comment.
Don't remove the file-ending newline. (Here, too.)
| @options[:ssl_ca_cert_path] = path | ||
| end | ||
|
|
||
| # Sets the ssl cert store |
There was a problem hiding this comment.
The other docstrings end with a period (.), do we want to harmonize with that?
|
Any update on that? It is really important for me :( |
|
Closing in favor of #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people might find it useful to use ca_cert path and cert store, like in Faraday