Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #81 #82

Merged
merged 1 commit into from
Feb 11, 2013
Merged

Fix for issue #81 #82

merged 1 commit into from
Feb 11, 2013

Conversation

lgustafson
Copy link
Contributor

This fix for issue #81 will allow the adapters with ssl support (net/http, curb, httpclient) to send client-side certificates even when ssl verify mode is set to none.

@rogerleite
Copy link
Member

@lgustafson You're right. On httpi version 1.1.1, it send client-side certificates like you said. Link here: https://github.com/savonrb/httpi/blob/v1.1.1/lib/httpi/adapter/net_http.rb#L86..L91 You can make some tests about this? The idea is to avoid to happen again.

@rubiii need your help here. What do you think?

@rubiii
Copy link
Contributor

rubiii commented Jan 22, 2013

@rogerleite you're right. this looks like a regression and we need more specs for it.

@rogerleite
Copy link
Member

@lgustafson I'm gonna merge the PR on this weekend. Thanks for contribution!
@rubiii I did tests for all adapters unless net/http, that have some TODOs on spec. Ok?

@rubiii
Copy link
Contributor

rubiii commented Feb 8, 2013

@rogerleite todo?

@rogerleite
Copy link
Member

@rubiii https://github.com/savonrb/httpi/blob/master/spec/httpi/adapter/net_http_spec.rb#L99 this line below, is kind of TODO marking for me. 😄

@rubiii
Copy link
Contributor

rubiii commented Feb 9, 2013

@rogerleite yeah, i noticed that just recently and obviously forgot to add an issue for it. thank you 😊

@ghost ghost assigned rogerleite Feb 11, 2013
rogerleite added a commit that referenced this pull request Feb 11, 2013
Send client-side certificates (if present) regardless of the state of ssl verify_mode (Fix for issue #81)
@rogerleite rogerleite merged commit d2838a4 into savonrb:master Feb 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants