Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some warnings #166

Merged
merged 1 commit into from
Apr 29, 2016
Merged

fix some warnings #166

merged 1 commit into from
Apr 29, 2016

Conversation

dx7
Copy link

@dx7 dx7 commented Jan 12, 2016

Running specs before the changes with RUBYOPT=-w:

Ruby Warnings resolved:

 162 lib/httpi/request.rb:108: warning: instance variable @on_body not initialized
 147 lib/httpi/request.rb:59: warning: instance variable @ssl not initialized
 100 lib/httpi/response.rb:53: warning: instance variable @body not initialized
  40 lib/httpi/auth/ssl.rb:66: warning: instance variable @ssl_version not initialized
   1 spec/httpi/auth/ssl_spec.rb:6: warning: ambiguous first argument; put parentheses or a space even after `/' operator
   1 spec/httpi/adapter/curb_spec.rb:261: warning: ambiguous first argument; put parentheses or a space even after `/' operator
   1 spec/httpi/adapter/curb_spec.rb:260: warning: ambiguous first argument; put parentheses or a space even after `/' operator
   1 lib/httpi/response.rb:47: warning: instance variable @body not initialized
   1 lib/httpi/auth/ssl.rb:13: warning: ambiguous first argument; put parentheses or a space even after `/' operator
   1 lib/httpi.rb:106: warning: instance variable @query_builder not initialized

@rogerleite
Copy link
Member

Hi @dx7! Thanks for this PR.

I don't know why, Travis is not happy and is failing, i need to look for what is breaking it.

Thanks again, i'll merge this soon.

@dx7
Copy link
Author

dx7 commented Jan 21, 2016

👍

@rogerleite rogerleite merged commit 21cf0f8 into savonrb:master Apr 29, 2016
@dx7
Copy link
Author

dx7 commented Apr 29, 2016

Thanks for the merge.

@rogerleite
Copy link
Member

👍 v2.4.2 released! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants