Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ntlm-http dependency #29

Closed
trampoline opened this issue Apr 6, 2011 · 7 comments
Closed

update ntlm-http dependency #29

trampoline opened this issue Apr 6, 2011 · 7 comments

Comments

@trampoline
Copy link

not sure what to do here :

https://github.com/trampoline/ntlm-http/tree/new-version-0.1.2.1

fixes

  • KConv compatability issues in net/ntlm when running under JRuby
  • issues with ntlm authentication when a windows domain must be specified

but there seem to be several versions of ntlm-http gem floating around already and i have no idea which is authoritative

http://rubygems.org/search?utf8=%E2%9C%93&query=ntlm-http

as it is, installing savon+httpi gets you an ntlm-http which won't work against windows soap services which require ntlm auth with a windows domain, which is just about every exchange-web-services instance in the wild, and probably many other services too

:c

@rubiii
Copy link
Contributor

rubiii commented Apr 28, 2011

what about making it an optional dependency and try to require net/ntlm lazy when it's used?

@trampoline
Copy link
Author

that's probably worse : then it would be up to the user to figure out which version of the several ntlm-http out there to install

the sensible ways seem to be :

  • get the owners of the original ntlm-http gem to update
    or
  • create yet another version of ntlm-http gem to depend on

that way savon/httpi users don't end up tearing their hair out with 401-Unauthorized exceptions

i emailed the authors of the original ntlm-http gem to see what they want to do

@rubiii
Copy link
Contributor

rubiii commented May 10, 2011

@trampoline please let me know when you receive a response.

@trampoline
Copy link
Author

original authors are not responding : one bouncing address ( [email protected]
), and one unresponsive hotmail account ( [email protected] )

i will fork a version of the ntlm-http gem

@rubiii
Copy link
Contributor

rubiii commented May 10, 2011

there might be a fix. please take a look at https://github.com/rubiii/savon/issues/163 and let me know if pyu-ntlm-http works for you.

@trampoline
Copy link
Author

pyu-ntlm-http should be fine : v0.1.3.1 has my fixes in :)

rubiii added a commit that referenced this issue May 15, 2011
this fixes a very annyoing problem with ntlm-http monkey patching the
net/http response.
@rubiii
Copy link
Contributor

rubiii commented May 15, 2011

this should be fixed with version 0.9.4.

@rubiii rubiii closed this as completed May 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants