Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to unwrap array of hashes #52

Merged
merged 1 commit into from
Mar 11, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions lib/gyoku/array.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,27 @@ class Array
# Translates a given +array+ to XML. Accepts the XML +key+ to add the elements to,
# whether to +escape_xml+ and an optional Hash of +attributes+.
def self.to_xml(array, key, escape_xml = true, attributes = {}, options = {})

self_closing = options.delete(:self_closing)
iterate_with_xml array, attributes do |xml, item, attrs, index|
unwrap = options[:unwrap] || false

iterate_with_xml array, key, attributes, options do |xml, item, attrs, index|
if self_closing
xml.tag!(key, attrs)

else
case item
when ::Hash then xml.tag!(key, attrs) { xml << Hash.to_xml(item, options) }
when ::Array then xml.tag!(key, attrs) { xml << Array.to_xml(item, NESTED_ELEMENT_NAME) }
when NilClass then xml.tag!(key, "xsi:nil" => "true")
else xml.tag!(key, attrs) { xml << XMLValue.create(item, escape_xml) }
when ::Hash then
if unwrap
xml << Hash.to_xml(item, options)
else
xml.tag!(key, attrs) { xml << Hash.to_xml(item, options) }
end
when ::Array then
xml.tag!(key, attrs) { xml << Array.to_xml(item, NESTED_ELEMENT_NAME) }
when NilClass then
xml.tag!(key, "xsi:nil" => "true")
else
xml.tag!(key, attrs) { xml << XMLValue.create(item, escape_xml) }
end
end
end
Expand All @@ -31,8 +41,24 @@ def self.to_xml(array, key, escape_xml = true, attributes = {}, options = {})

# Iterates over a given +array+ with a Hash of +attributes+ and yields a builder +xml+
# instance, the current +item+, any XML +attributes+ and the current +index+.
def self.iterate_with_xml(array, attributes)
def self.iterate_with_xml(array, key, attributes, options, &block)

xml = Builder::XmlMarkup.new
unwrap = options[:unwrap] || false

if (unwrap)
xml.tag!(key) { iterate_array(xml, array, attributes, &block) }
else
iterate_array(xml, array, attributes, &block)
end

xml.target!
end


# Iterates over a given +array+ with a Hash of +attributes+ and yields a builder +xml+
# instance, the current +item+, any XML +attributes+ and the current +index+.
def self.iterate_array(xml, array, attributes, &block)
array.each_with_index do |item, index|
if item.respond_to?(:keys)
attrs = item.reduce({}) do |st, v|
Expand All @@ -45,9 +71,9 @@ def self.iterate_with_xml(array, attributes)
end
yield xml, item, tag_attributes(attributes, index).merge(attrs), index
end
xml.target!
end


# Takes a Hash of +attributes+ and the +index+ for which to return attributes
# for duplicate tags.
def self.tag_attributes(attributes, index)
Expand Down
7 changes: 7 additions & 0 deletions spec/gyoku/array_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@
expect(to_xml(array, "user")).to eq(result)
end

it "returns the XML for an Array of Hashes unwrapped" do
array = [{ :name => "adam" }, { :name => "eve" }]
result = "<user><name>adam</name><name>eve</name></user>"

expect(to_xml(array, "user", true, {}, :unwrap => true)).to eq(result)
end

it "returns the XML for an Array of different Objects" do
array = [:symbol, "string", 123]
result = "<value>symbol</value><value>string</value><value>123</value>"
Expand Down