Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Arrays of @attributes (tests ok) #30

Merged
merged 8 commits into from
Jun 30, 2013
Merged

Conversation

razum2um
Copy link
Contributor

on upstream/master it acts unexpectedly
see tests on upstream

..............................FF..............................

Failures:

  1) Gyoku::Hash.to_xml recognizes array of attributes
     Failure/Error: to_xml(hash).should == '<category name="one"></category><category name="two"></category>'
       expected: "<category name=\"one\"></category><category name=\"two\"></category>"
            got: "<category></category><category></category>" (using ==)
     # ./spec/gyoku/hash_spec.rb:214:in `block (3 levels) in <top (required)>'

  2) Gyoku::Hash.to_xml recognizes array of attributes with selfclosing tag
     Failure/Error: to_xml(hash).should == '<category name="one"/><category name="two"/>'
       expected: "<category name=\"one\"/><category name=\"two\"/>"
            got: "<category></category><category></category>" (using ==)
     # ./spec/gyoku/hash_spec.rb:221:in `block (3 levels) in <top (required)>'

Finished in 0.0277 seconds
62 examples, 2 failures

this fixes it

@rubiii
Copy link
Contributor

rubiii commented Jun 19, 2013

thanks @razum2um! could you add some information about this to the changelog?

@razum2um
Copy link
Contributor Author

@rubiii see updated README and let me know, what you think

@razum2um
Copy link
Contributor Author

Would be glad to add ruby-2.0 to travis matrix (now passed) & bump version

@rubiii
Copy link
Contributor

rubiii commented Jun 29, 2013

this looks very good. thanks again! i left a comment on a hacky piece of code i'd like to see resolved,
but apart from that i'd be happy to merge.

@razum2um
Copy link
Contributor Author

@rubiii yeah, i got it working without hack

@rubiii
Copy link
Contributor

rubiii commented Jun 30, 2013

perfect 👍

rubiii added a commit that referenced this pull request Jun 30, 2013
Support of array of @attributes (tests ok)
@rubiii rubiii merged commit db9a327 into savonrb:master Jun 30, 2013
This was referenced Jul 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants