Attempt#2: support for explicit node attributes using keys beginning with "@" #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for updating this one guys! |
rubiii
added a commit
that referenced
this pull request
Dec 15, 2012
Attempt#2: support for explicit node attributes using keys beginning with "@"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, building collectional xml nodes like
having Flights objects array makes me iterate over it twice: one time to build bodies, the second time to build attributes. This gets even worse if these cases are nested.
So I rebased #10 on your master, but changed _content to :content! This seems more natural for this lib
Tests included