Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uppercase convert_symbols_to formula #17

Merged
merged 1 commit into from
Dec 15, 2012
Merged

Conversation

cdinger
Copy link
Contributor

@cdinger cdinger commented Jul 19, 2012

Thanks, @rubiii for writing and maintaining Savon! It's the first SOAP tool that I've actually been able to use in a complex Oralce/PeopleSoft environment.

This change would dramatically clean up our code; all of the Oracle web services we use have uppercase keys. Right now, it's a pain because we have to convert ActiveRecord attributes to uppercase strings.

Please consider.... Thanks!

@rubiii
Copy link
Contributor

rubiii commented Jul 24, 2012

looks good. i'll try to merge and release later today.

@cdinger
Copy link
Contributor Author

cdinger commented Jul 24, 2012

@rubiii, I just realized that the README mentions the ability to define your own symbol conversion formula—it even uses upcase as an example:

Gyoku.convert_symbols_to { |key| key.upcase }
Gyoku.xml(:upcase => "key")
# => "<UPCASE>key</UPCASE>"

I hadn't realized this when I submitted this pull request! This feature probably isn't necessary. If you do want to merge, I can update the README with a less confusing custom formula example... Let me know.

Thanks again!

@rubiii
Copy link
Contributor

rubiii commented Jul 24, 2012

yeah :) sorry, i should have mentioned that. but upcase seems to be a legitimate formula to support.
don't know if i need to release something today, now that you found this feature, but i'll include it in the next release.

@cdinger
Copy link
Contributor Author

cdinger commented Jul 24, 2012

Perfect. I updated the commit with a README change for when you do release. Thanks!

@rubiii
Copy link
Contributor

rubiii commented Jul 24, 2012

thank you very much!

rubiii added a commit that referenced this pull request Dec 15, 2012
uppercase convert_symbols_to formula
@rubiii rubiii merged commit 86ae711 into savonrb:master Dec 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants