Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix. Incorrect warning of LONG_NUMERICAL_VALUES_SEPARATED. #660

Merged
merged 4 commits into from
Dec 28, 2020
Merged

BugFix. Incorrect warning of LONG_NUMERICAL_VALUES_SEPARATED. #660

merged 4 commits into from
Dec 28, 2020

Conversation

Animeshz
Copy link
Contributor

@Animeshz Animeshz commented Dec 21, 2020

When number of length exactly maxNumberLength is presented the warning was issued.

Fixes the above issue and also updated available-rules.md which was corresponding to old (outdated) settings for this rule.

…n exactly maxNumberLength number is presented. Updates available-rules.md (that was undocumented/outdated)
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Animeshz! Your change looks reasonable for me, but please fix failing CI builds.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #660 (b4c5ba0) into master (731b86d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #660   +/-   ##
=========================================
  Coverage     79.24%   79.24%           
  Complexity     1803     1803           
=========================================
  Files            87       87           
  Lines          4708     4708           
  Branches       1513     1513           
=========================================
  Hits           3731     3731           
  Misses          280      280           
  Partials        697      697           
Flag Coverage Δ Complexity Δ
unittests 79.24% <100.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../ruleset/rules/LongNumericalValuesSeparatedRule.kt 89.70% <100.00%> (ø) 24.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731b86d...b4c5ba0. Read the comment docs.

@petertrr petertrr merged commit 2faaefc into saveourtool:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants