Gradle plugin tests & fixes #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Improvements
### What's done: * Improvements
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
============================================
+ Coverage 79.01% 79.23% +0.21%
- Complexity 1792 1799 +7
============================================
Files 88 87 -1
Lines 4704 4695 -9
Branches 1510 1508 -2
============================================
+ Hits 3717 3720 +3
+ Misses 288 280 -8
+ Partials 699 695 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * improvements
### What's done: * Removed custom GradleVersion
### What's done: * Make excludes non-nullable
### What's done: * Code style
### What's done: * Test with absolute paths * Test with gradle 5.0
…eature/gradle-tests#653
### What's done: * Respect ignoreFailures property * More functional tests * Functional tests for groovy DSL
### What's done: * Functional tests for groovy DSL
### What's done: * Functional tests for groovy DSL
kentr0w
requested changes
Dec 22, 2020
diktat-gradle-plugin/src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/Utils.kt
Show resolved
Hide resolved
diktat-gradle-plugin/src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/Utils.kt
Show resolved
Hide resolved
aktsay6
reviewed
Dec 22, 2020
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/Utils.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #653