Fix for incorrect variable name handle #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Added fix for incorrect variable handle and tests
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
============================================
- Coverage 79.07% 79.01% -0.06%
- Complexity 1787 1792 +5
============================================
Files 88 88
Lines 4697 4704 +7
Branches 1506 1510 +4
============================================
+ Hits 3714 3717 +3
Misses 288 288
- Partials 695 699 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Fixed according our code-style
petertrr
requested changes
Dec 16, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph1/naming/identifiers/VariableNamingTest.kt
Show resolved
Hide resolved
### What's done: Fixed after review
petertrr
requested changes
Dec 21, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
### What's done:
Fixed after review
petertrr
requested changes
Dec 21, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
### What's done:
Fixed after review
### What's done:
Fixed after review
petertrr
approved these changes
Dec 22, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
### What's done:
Final fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Added fix for incorrect variable handle and tests
closes #402