Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code coverage in maven plugin #644

Merged
merged 18 commits into from
Dec 21, 2020
Merged

code coverage in maven plugin #644

merged 18 commits into from
Dec 21, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 15, 2020

What's done:

  • More unit tests
  • More integration tests
  • Configured jacoco to generate reports for integration tests

This pull request closes #631

### What's done:
* Fixed pom.xml
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #644 (1679f28) into master (f6786c2) will increase coverage by 0.15%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #644      +/-   ##
============================================
+ Coverage     78.91%   79.07%   +0.15%     
+ Complexity     1789     1787       -2     
============================================
  Files            88       88              
  Lines          4696     4697       +1     
  Branches       1506     1506              
============================================
+ Hits           3706     3714       +8     
+ Misses          298      288      -10     
- Partials        692      695       +3     
Flag Coverage Δ Complexity Δ
unittests 79.07% <50.00%> (+0.15%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../kotlin/org/cqfn/diktat/plugin/maven/DiktatMojo.kt 10.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 21.05% <66.66%> (+13.90%) 0.00 <0.00> (-2.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6786c2...1679f28. Read the comment docs.

### What's done:
* WIP: GH packages, maven example
### What's done:
* maven tests
@petertrr petertrr marked this pull request as ready for review December 16, 2020 09:42
### What's done:
* Fixed code in examples
### What's done:
* Fixed code in examples
### What's done:
* Added jacoco agent via .mvn/jvm.config
### What's done:
* Added jacoco agent via .mvn/jvm.config
### What's done:
* Tests on diktat:fix
### What's done:
* Changed !== to !=
@petertrr petertrr requested a review from aktsay6 December 17, 2020 16:02
### What's done:
* resolveConfig returns non-nullable
@petertrr petertrr requested a review from orchestr7 December 21, 2020 09:31
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now looks good, thanks!

@petertrr petertrr merged commit e71d22e into master Dec 21, 2020
@petertrr petertrr deleted the infra/maven-it-codecov#631 branch December 21, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low reported code coverage in diktat-maven-plugin
3 participants