Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snapshot build in functional tests #643

Merged
merged 30 commits into from
Dec 18, 2020
Merged

Use snapshot build in functional tests #643

merged 30 commits into from
Dec 18, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 14, 2020 •
edited
Loading

What's done:

  • Upload diktat.jar from build_and_test
  • Run CLI diktat using snapshot jar
  • Run all tests on different platforms
  • Removed functional_tests.yml

This pull request closes #625

@petertrr
Use snapshot build in functional tests
873e7b1 
### What's done:
* WIP: CLI run
@codecov
Copy link

codecov bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

Merging #643 (0894a4e) into master (6e60194) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #643   +/-   ##
=========================================
  Coverage     78.91%   78.91%           
  Complexity     1789     1789           
=========================================
  Files            88       88           
  Lines          4696     4696           
  Branches       1506     1506           
=========================================
  Hits           3706     3706           
  Misses          298      298           
  Partials        692      692
Flag Coverage Δ Complexity Δ
unittests 78.91% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e60194...0894a4e. Read the comment docs.

@petertrr
Use snapshot build in functional tests
89783c3 
### What's done:
* WIP: GH packages
@petertrr
Use snapshot build in functional tests
17ac3ba 
### What's done:
* WIP: GH packages
* Removed distributionManagement from parent pom
@petertrr
Update build_and_test.yml
a66db63
@petertrr
Update build_and_test.yml
ed95dfe
@petertrr
Update build_and_test.yml
a35d176
@petertrr
Update build_and_test.yml
3c8de3e
@petertrr
Use snapshot build in functional tests
71a4217 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
279e514 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
2fef56b 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
ac79541 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
201cfb5 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
ff756fc 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
d6ae5c1 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
3087728 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
238f97f 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
40a98bd 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
219581a 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
88c739d 
### What's done:
* WIP: GH packages, maven example
@petertrr petertrr force-pushed the infra/ci-refactoring#625 branch from de7cb30 to d9d2301 Compare December 15, 2020 13:56
@petertrr
Use snapshot build in functional tests
d9d2301 
### What's done:
* WIP: GH packages, maven example
@petertrr
Use snapshot build in functional tests
196fab5 
### What's done:
* WIP: GH packages, maven example
@petertrr
Refoctoring functional tests
2a2a797 
### What's done:
* Removed functional tests workflow
* Do not use github packages
* Run all tests on different platforms
@petertrr
Merge branch 'master' into infra/ci-refactoring#625
8f86cd8
@petertrr
Update build_and_test.yml
1c854fe
@petertrr
Update build_and_test.yml
5076022
@petertrr
Refactoring functional tests
61cdf1d 
### What's done:
* Fixes
@petertrr
Refactoring functional tests
35fa94a 
### What's done:
* Fixes
@petertrr
Merge branch 'master' into infra/ci-refactoring#625
a3a2b16
@petertrr
Refactoring functional tests
d2452c4 
### What's done:
* Fixes
@petertrr petertrr marked this pull request as ready for review December 17, 2020 08:05
@petertrr petertrr changed the title WIP: Use snapshot build in functional tests Use snapshot build in functional tests Dec 17, 2020
@petertrr petertrr requested a review from kentr0w December 18, 2020 15:34
kentr0w
kentr0w approved these changes Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 7237a31 into master Dec 18, 2020
@petertrr petertrr deleted the infra/ci-refactoring#625 branch December 18, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentr0w kentr0w kentr0w approved these changes

@orchestr7 orchestr7 Awaiting requested review from orchestr7

@aktsay6 aktsay6 Awaiting requested review from aktsay6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run functional tests with diktat snapshot build
2 participants
@petertrr @kentr0w